Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GearButton #851

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Add GearButton #851

merged 1 commit into from
Dec 3, 2020

Conversation

Tanvez
Copy link
Contributor

@Tanvez Tanvez commented Nov 24, 2020 •
edited
Loading

Fixes #835
Added the GearButton and aria for accessibility

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@Tanvez Tanvez requested a review from adamkendis November 24, 2020 20:04
adamkendis
adamkendis approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Vez, sorry for the delay on this. Looks good to me!

@Tanvez Tanvez merged commit 2dcf7c4 into dev Dec 3, 2020
@Tanvez Tanvez deleted the 835-settingGear-button branch December 3, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkendis adamkendis adamkendis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings/gear button - map (mobile/desktop)
2 participants
@Tanvez @adamkendis