Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling cypress for now #820

Merged
merged 1 commit into from
Oct 5, 2020
Merged

disabling cypress for now #820

merged 1 commit into from
Oct 5, 2020

Conversation

jmensch1
Copy link
Contributor

@jmensch1 jmensch1 commented Oct 5, 2020

This just disables the github action that runs the cypress tests. The tests are far from complete and are sometimes causing problems with PRs. Plus they run against the code that's already on the dev server rather than the code that's actually being pushed, which doesn't make much sense.

In order to use Cypress properly in CI/CD we'd need to have a github action that fires up both the api and the frontend, and then runs the cypress tests against that app instead of the one on dev.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jmensch1 jmensch1 requested a review from adamkendis October 5, 2020 04:20
@adamkendis adamkendis merged commit 8a2bc81 into dev Oct 5, 2020
@adamkendis adamkendis deleted the DisableCypress branch October 5, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants