558 front hamburger menu #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se anchor is required for Bulma implementation
1 task
adamkendis
suggested changes
Sep 10, 2020
There was a problem hiding this comment.
Hey Nate, sorry for the delay reviewing this. The burger menu looks and works great - tested in Chrome, Firefox, Edge changing browser zoom level and viewport size.
Just a small change on the aria-expanded burger menu attribute and some comments on splitting the menu links.
|
I've been trying to fix the cypress failure for the longest time...I need help! |
|
See #805. This should fix the failing cypress test. |
…ponsive styling, navbar items moved back right
adamkendis
suggested changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{558}
devbranchAny questions? See the getting started guide