Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

581 filter menu - error handling for data and comparison forms #783

Merged
merged 18 commits into from Aug 21, 2020
Merged

581 filter menu - error handling for data and comparison forms #783

merged 18 commits into from Aug 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 19, 2020 •
edited by adamkendis
Loading

Fixes #581

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Screen Shot 2020-08-19 at 3 46 59 PM

Hannah Livnat added 16 commits August 14, 2020 16:29
added * message and asterisks to all required fields
5dca5fb
started working on error boundaries and messaging. Added formerrorcom…
8b11406 
…ponent, starting to work on error messaging within handleSubmit function to combine the handleSubmit and submitbutton disabling logic
took out submit button disable and added in form validation for data …
0e2fbc4 
…and comparison maps. Currently able to log whether each value is filled out, but currently erroring on submit
deleted useEffect for disabled button in submit.jsx
0c80fca
deleted extra spaces
4bcc8be
trying to pass down error messaging from menu to submit, learning mor…
6127e2b 
…e about react redux connect tomorrow
succesfully passing errors from submit component to menu component th…
554fa08 
…rough props
error message stating to choose at least one selection displayed on s…
aeeeb65 
…ubmit
missed one hardcoded selector warning in menu
f77f500
deleted console.logs used for testing
47ee4c3
combined repeated code for updated error messages
453fc79
changes to fix portion of lint errors
d7ed740
more fixes for lint
bffb7e0
lint
7f3647b
fixed unnecessary ternary
36ca5e0
more lint
651c1d0
@ghost ghost requested a review from adamkendis August 19, 2020 22:55
adamkendis
adamkendis suggested changes Aug 20, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Just some changes for specific error messaging and a couple small comments.

node_modules_non_es5 Show resolved Hide resolved
client/components/main/menu/Menu.jsx Outdated Show resolved Hide resolved
client/components/main/menu/Menu.jsx Outdated Show resolved Hide resolved
adamkendis
adamkendis approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adamkendis adamkendis merged commit 71b1acd into hackforla:dev Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Menu - Improve form validation, add error messaging
1 participant
@adamkendis