Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend - repo cleanup #779

Merged
merged 4 commits into from
Aug 13, 2020
Merged

Conversation

adamkendis
Copy link
Member

@adamkendis adamkendis commented Aug 13, 2020

  • Renamed src/ -> client/
  • Pulled all front-end related files into client/: babel, eslint, webpack, package/package-lock.json
  • Updated all refs to src/
  • Removed package-lock.json from .gitignore. We should be committing the most recent working dependency tree.

Note: All frontend npm scripts will be run from the client/ directory now

Screen Shot 2020-08-13 at 2 02 16 PM

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@adamkendis adamkendis requested review from jmensch1, tan-nate and a user August 13, 2020 21:19
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, project structure looks great now. I'll take a look at the /bin folder, I know I put some stuff in there but not sure it's needed any more.

Agree with you about the package-lock.json.

Good stuff!

@adamkendis adamkendis merged commit 81656e3 into hackforla:dev Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants