Analytics scripts, pie chart tweak #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmensch1
approved these changes
Jul 20, 2020
adamkendis
commented
Jul 30, 2020
| @@ -69,7 +69,7 @@ const Submit = ({ | |||
| } | |||
| break; | |||
| } | |||
| default: return null; | |||
| default: return undefined; | |||
There was a problem hiding this comment.
Changed to return undefined because react devtools was warning that effect functions shouldn't return null.
|
Hey @jmensch1 , finally finished this up. Added a few more commits to include small changes discussed last meeting. New commit summary added in PR message. |
adamkendis
added
the
Do Not Merge
|
Hold off on merging. Resolving some route issues. |
adamkendis
removed
the
Do Not Merge
|
Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #745, fixes #746, fixes #747, fixes #748, fixes #749
placeholderprop to MultiSelect SearchBar for custom placeholder text.EDIT for additional commits:
Updated placeholder text for NCSelector and CCSelector and made text darker grey.
Changed header link text and removed color from Comparison link.
Removed the convoluted splashPage redux stuff. Added a
/dataroute for the 311 Data Tool.Removed trailing semicolon from list of selected request types in Comparison Criteria.
devbranchAny questions? See the getting started guide