Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map features, About page changes #665

Merged
merged 7 commits into from
Jun 2, 2020

Conversation

adamkendis
Copy link
Member

Fixes #610
Fixed #646

Heatmap Legend and Export Legend

  • Pulled heatmap legend into its own component wrapped in <Control> - visible with Heatmap overlay enabled.
  • Implemented Export Legend - visible with Markers overlay enabled.
  • Wrapping the legends in <Control> renders them in the leaflet controls container and resolves legend overlapping on some browser zoom levels.

Additional map controls

  • Enabled map scale bar.

About Page

  • Updated hero image - will probably update again after talking to UI this evening.

  • Replaced svgs with pngs - was running into some scaling issues.

  • Made the About page the splash page for the / path. The About page will render on initial / pageload. After navigating away, splash page at / is disabled. The implementation seems really clumsy and I might refactor later, but it's working now.

    • Up to date with dev branch
    • Branch name follows guidelines
    • All PR Status checks are successful
    • Peer reviewed and approved

Any questions? See the getting started guide

@adamkendis adamkendis added this to the 311-Data - Beta milestone Jun 2, 2020
@adamkendis adamkendis requested a review from jmensch1 June 2, 2020 19:23
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jmensch1 jmensch1 merged commit 7c77f32 into hackforla:dev Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About 311 Page Changes Map features for beta release
2 participants