calculating _daystoclose during ingest; nc code fixes #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellnat77
reviewed
May 4, 2020
| log('\nCleaning ingest table.') | ||
| table = Ingest.__tablename__ | ||
| report = [] | ||
|
|
||
| dropDuplicates(table, report) | ||
| switchPrimaryKey(table, report) | ||
| removeInvalidClosedDates(table, report) | ||
| setDaysToClose(table, report) | ||
| fixNorthWestwood(table, report) |
There was a problem hiding this comment.
@ryanmswan This looked fine to me but i just want a sanity check before this gets merged pleassseee 🙏
sellnat77
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three cleaning tasks to the end of the ingest script.
/timetocloseendpoint (fixing calculate time to close during ingest #528)nccolumn. Sets it to the correct code of 127.devbranchAny questions? See the getting started guide