Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc frontend fixes - HashRouter, NavLinks, styling changes. #490

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Misc frontend fixes - HashRouter, NavLinks, styling changes. #490

merged 3 commits into from
Apr 3, 2020

Conversation

adamkendis
Copy link
Member

  • Replaced BrowserRouter with HashRouter to resolve routing issues with github-pages. Adds an ugly hash symbol to the url but allows the user to refresh the browser or go straight to different pages without getting a 404. Limited options until (if) we migrate the front end away from github-pages.
  • Replaced some header Links with NavLink. Added yellow underline for active NavLink.
  • Slightly reduced NCSelector height and padding on Submit to try to fit entire menu on (more) screen sizes.
  • Changed menu overflow to auto (instead of scroll) so scrollbar only shows when there is content overflow.

@adamkendis adamkendis requested review from brodly and jmensch1 April 3, 2020 00:37
@brodly brodly merged commit d91767e into hackforla:dev Apr 3, 2020
@adamkendis adamkendis mentioned this pull request May 13, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodly brodly brodly approved these changes

@jmensch1 jmensch1 jmensch1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
311 Data Alpha - Dev Complete
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkendis @jmensch1 @brodly