Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG webpack fix #473

Merged
merged 5 commits into from
Mar 27, 2020
Merged

SVG webpack fix #473

merged 5 commits into from
Mar 27, 2020

Conversation

adamkendis
Copy link
Member

@adamkendis adamkendis commented Mar 27, 2020 •
edited
Loading

  • Added react-svg-loader to webpack for svg files. This allows inline svg use by importing and using svg files directly in React components. Babel transpiles the svg markup into the bundle. No need to fetch svgs.

  • Removed svg from webpack file-loader.

    • Up to date with dev branch
    • Branch name follows guidelines
    • All PR Status checks are successful
    • Peer reviewed and approved

@adamkendis adamkendis requested review from brodly and jmensch1 March 27, 2020 05:20
jmensch1
jmensch1 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@jmensch1 jmensch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@brodly brodly merged commit 570b59d into hackforla:dev Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodly brodly brodly approved these changes

@jmensch1 jmensch1 jmensch1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkendis @jmensch1 @brodly