Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix style loading prod issue #274

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Hot fix style loading prod issue #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
243fb7a
Fixed styles not loading properly
brodly Feb 21, 2020
3fdff7f
Added temp scroll to menubar
brodly Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@
<body class="has-navbar-fixed-bottom">
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<script src="bundle.js"></script>
</body>
</html>
5 changes: 5 additions & 0 deletions src/components/main/menu/Menu.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ const Menu = () => {
<div
id="sidebar-wrapper"
className="sidebar-content"
// TODO: Fix this for better handling of height
style={{
height: '85vh',
overflowY: 'scroll',
}}
>

{/* Tabs */}
Expand Down
3 changes: 1 addition & 2 deletions webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ module.exports = {
entry: './src/index.js',
output: {
path: path.join(__dirname, '/dist'),
publicPath: '/',
filename: 'bundle.js',
},
resolve: {
Expand Down Expand Up @@ -53,7 +52,7 @@ module.exports = {
title: '311-Data',
}),
new MiniCssExtractPlugin({
filename: 'css/styles.css',
filename: '[name].css',
}),
],
};