Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

155 nc selector #259

Merged
merged 16 commits into from
Feb 17, 2020
Merged

155 nc selector #259

merged 16 commits into from
Feb 17, 2020

Conversation

brodly
Copy link
Member

@brodly brodly commented Feb 16, 2020

Fixed #155

Updated Bulma to 7.8 to use optional chaining
Added icons to button component
Added sidebar button toggle
Formatted sidebar for accepting new components

Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, but everything looks good.

src/components/common/Button.jsx Show resolved Hide resolved
src/components/main/menu/NCSelector.jsx Show resolved Hide resolved
src/components/main/menu/NCSelector.jsx Show resolved Hide resolved
src/components/main/menu/NCSelector.jsx Show resolved Hide resolved
src/components/main/menu/NCSelector.jsx Show resolved Hide resolved
src/redux/reducers/data.js Show resolved Hide resolved
@adamkendis adamkendis self-requested a review February 17, 2020 19:16
Copy link
Member

@adamkendis adamkendis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's talk about redux at tomorrow's meeting.

@adamkendis adamkendis merged commit 8ca7edf into dev Feb 17, 2020
@adamkendis adamkendis deleted the 155_nc_selector branch February 17, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants