Fixes #235 Enforced a frontend linting step to protect PRs #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellnat77
force-pushed
the
235_FE_linting
branch
from
bccecf6 to
a65f5fd
Compare
brodly
reviewed
Feb 10, 2020
|
This is fine. We might run into an annoying issue where the linter is enforcing accessibility. We can turn that down to warning or off for now and then add accessibility for MVP+ |
|
Gonna take me a bit to address the existing errors but ill post in the channel when this PR is primed and ready |
sellnat77
force-pushed
the
235_FE_linting
branch
from
d284321 to
a76760c
Compare
sellnat77
commented
Feb 10, 2020
src/components/common/Dropdown.jsx
Outdated
| </span> | ||
| </button> | ||
| </div> | ||
| <div className="dropdown-menu" id="dropdown-menu" role="menu"> | ||
| <div className="dropdown-content"> | ||
| <a href="#" className="dropdown-item"> | ||
| <button |
There was a problem hiding this comment.
This was probably the most strange change but seeing as how this isnt being used yet im sure we can figure out a lint-safe way to do this
There was a problem hiding this comment.
pull latest dev, this has been fixed
Actually running linting Addressed all linting errors Removed unused test
sellnat77
force-pushed
the
235_FE_linting
branch
from
a76760c to
7810808
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235