Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CodeForAmerica logo w/ CTS logo #1640

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

Skydodle
Copy link
Member

@Skydodle Skydodle commented Dec 7, 2023

Fixes #1639

  • Added CTS Logo from Figma file to project's assets folder & deleted the old logo

  • Replaced old codeForAmerica logo with CTS logo in About component

  • Up to date with dev branch

  • Branch name follows guidelines

  • All PR Status checks are successful

  • Peer reviewed and approved

Any questions? See the getting started guide

@Skydodle Skydodle requested review from edwinjue, funbunch and ryanfchase and removed request for funbunch December 7, 2023 07:00
@ryanfchase
Copy link
Member

These changes look good, and the dimensions line up with the figma, but I wanted to ask a discussion question on slack. Since this is a general discussion (not about your changes in particular) we can keep the discussion on Slack, and then seal in any workflow changes via guides/documentation.

I had a question about workflow and I wanted to know some pros vs cons. Johnny I noticed your PR (1640) is based on your fork. If I wanted to go and look at your code and confirm it visually looks ok, I don't think I have a good way of doing this besides cloning your fork. I know this is a limitation of not having an active test framework, but in the meantime I think we should enforce PRs to come from cloned repo. What do ya'll think?

@ryanfchase
Copy link
Member

ryanfchase commented Dec 15, 2023

Approving this PR, thanks @Skydodle, feel free to merge

@Skydodle Skydodle merged commit ee9fc4c into hackforla:main Dec 20, 2023
@Skydodle Skydodle deleted the 1639-replace-logo-in-about-page branch December 20, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Replace Org Logo on About Page
2 participants