Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1465 search filter request types #1466

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Conversation

edwinjue
Copy link
Member

Fixes #1465

There was an inconsistency with mapping the typeId between what we had locally and what was getting returned from our API server. I went ahead and synced the data and sorted our request types by an orderId property instead to fix this bug.

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

…x small bug requiring Select/Deselect All to be clicked twice initially to toggle
…ed from server API and added orderId property to each tempType object to allow tempTypes to be sorted according to UI specifications. I perform a sort by orderId in TypeSelector/index.js useEffect
@edwinjue edwinjue linked an issue Feb 20, 2023 that may be closed by this pull request
Copy link
Member

@bryantran04 bryantran04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edwinjue edwinjue merged commit 2b2fefb into dev Feb 22, 2023
@edwinjue edwinjue deleted the 1465-search-filter-request-types branch February 22, 2023 19:51
@edwinjue
Copy link
Member Author

Thanks @bryantran04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Filter - Request Types
2 participants