Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1284 new loading modal display #1412

Merged
merged 2 commits into from
Nov 10, 2022
Merged

1284 new loading modal display #1412

merged 2 commits into from
Nov 10, 2022

Conversation

jekijo
Copy link
Member

@jekijo jekijo commented Nov 9, 2022

Fixes #{1284}

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@jekijo jekijo requested review from edwinjue and nichhk November 9, 2022 23:52
@jekijo
Copy link
Member Author

jekijo commented Nov 9, 2022

Hey guys, the only thing I should mention about the new loading bar is that the gif isn't super smooth while looping, however it displays properly while data is being fetched and disappears once the data has loaded.

@jekijo jekijo merged commit 9e7dedc into dev Nov 10, 2022
@jekijo jekijo deleted the 1284-new-loading-modal-display branch November 10, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants