Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Contact form submit button does not show up when screen resolution height <= 690px #1353

Conversation

edwinjue
Copy link
Member

@edwinjue edwinjue commented Sep 9, 2022

Fixes #1352

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

…e, restoring fix from 595319c to add a grid container to the bottom of the contact form with a height equivalent to the footer to compensate for blocked visibility of the submit button
Copy link
Member

@nichhk nichhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edwin! One comment. Please merge after handling it.

client/components/contact/ContactForm.jsx Outdated Show resolved Hide resolved
@edwinjue edwinjue requested a review from nichhk September 9, 2022 23:17
@edwinjue edwinjue merged commit 9212512 into dev Sep 9, 2022
@edwinjue edwinjue deleted the 1352-contact-form-submit-button-does-not-show-up-when-screen-resolution-height-=-690px branch September 9, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact form submit button does not show up when screen resolution height <= 690px
2 participants