1308 fe preventing dates longer than 3 months #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nichhk
suggested changes
Sep 8, 2022
| @@ -162,6 +162,7 @@ async def get_open_request_counts(): | |||
| return result | |||
|
|
|||
|
|
|||
| @cached(alias="default") | |||
There was a problem hiding this comment.
Please delete this change from the PR
|
|
nichhk
suggested changes
Sep 9, 2022
| @@ -162,6 +162,7 @@ async def get_open_request_counts(): | |||
| return result | |||
|
|
|||
|
|
|||
| @cached(alias="default") | |||
nichhk
approved these changes
Sep 9, 2022
|
It's looking great! Would it be possible to cut the calendar length to align with the line on the dropdown? The calendar color also might blend in too much with the rest of the menu. Let me run that by Elizabeth to ask her thoughts on the calendar color. Could the calendar length have been extended to cover up the selection text below it? if so, that's another thing I might want to discuss with Elizabeth. We might be able to figure something out.
|
|
|
This was referenced Oct 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{1308}
devbranchWhile still able to click on and select dates outside of the available range when using the disabledDays arg, they are now greyed out and return no data when selected.