1270 enable eslint on all js files (partially fixed) #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nichhk
suggested changes
Aug 30, 2022
| } | ||
| }) | ||
| } | ||
| const updateAll = value => requestTypes.map(type => { |
There was a problem hiding this comment.
Let's use forEach here since we don't need to create a new array
There was a problem hiding this comment.
sounds good, changes made
client/redux/sagas/data.js
Outdated
| requestTypes: Object.keys(requestTypes).filter(req => req !== 'All' && requestTypes[req]), | ||
| }; | ||
| } | ||
| // function* getMapFilters() { |
There was a problem hiding this comment.
I'm guessing this function isn't being used? In that case, we can just delete it. Commented-out code is more confusing than useful in most cases.
There was a problem hiding this comment.
agreed, commented code has been removed
edwinjue
changed the title
…mponents/main/Desktop/TypeSelector/index.js
nichhk
approved these changes
Aug 30, 2022
| } | ||
| return null; | ||
| }); | ||
| function updateAll(value) { |
There was a problem hiding this comment.
while you're here (I know you didn't write this): nit: value -> isSelected
…in client/components/main/Desktop/TypeSelector/index.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1270
devbranchAny questions? See the getting started guide