Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact page fully functional. Utilizes Material UI design components and inherits styles from theme #1330
Contact page fully functional. Utilizes Material UI design components and inherits styles from theme #1330
Changes from 25 commits
f3c8cc9
2f6f6d2
025e3f7
12782ae
43db4cf
5821a6c
7fb307d
f3a73eb
216db4b
7df6c06
dbdb492
4c28f42
dca1d27
b2c08e0
2bb011f
1ed2871
d9c09e8
799bf10
1c80214
13f76a4
0df22a7
07530cf
3414da3
437c9d2
f6a54fe
95d2a0d
8a03971
ad333f6
435d4a4
60bcb80
b13a1d3
0e80c9f
ceb9a77
4c2c5c2
aa82a82
c1492a0
85be5b0
95327a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we have multiple TextFields with some subset of the same properties. Can we make a subclass or something of that sort so that we don't need to repeat all those properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to but I'm not sure if we can without creating our own TextField component that takes in an object that we can set as a prop but I think doing so would add more complexity to just using material-ui components as they are. However, if you or anyone else could suggest a way we could minimize repetitive code here, I'll be interested in trying it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jekijo or Jordan, any ideas?