add simple CircularProgress component when loading #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1284
Major changes:
Get rid of
isVisLoading
from redux state since it's not usedGet rid of redux-saga
takeEvery
forGET_DATA_REQUEST
, since we're already implementing the side effect outside of redux-sagaset
store.data.isMapLoading
every time we get new data, and unset it once we successfully retrieve the new datacreate a
CircularProgress
component whenstore.data.isMapLoading
is true. This is just a temporary solution until we have a design for an actual loading indicator.dev
branchAny questions? See the getting started guide