Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple CircularProgress component when loading #1304

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Aug 1, 2022

Partially fixes #1284

Major changes:

  • Get rid of isVisLoading from redux state since it's not used

  • Get rid of redux-saga takeEvery for GET_DATA_REQUEST, since we're already implementing the side effect outside of redux-saga

  • set store.data.isMapLoading every time we get new data, and unset it once we successfully retrieve the new data

  • create a CircularProgress component when store.data.isMapLoading is true. This is just a temporary solution until we have a design for an actual loading indicator.

    • Up to date with dev branch
    • Branch name follows guidelines
    • All PR Status checks are successful
    • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk linked an issue Aug 1, 2022 that may be closed by this pull request
2 tasks
@nichhk nichhk requested review from funbunch and ardada2468 August 1, 2022 18:56
@nichhk
Copy link
Member Author

nichhk commented Aug 2, 2022

Thanks for the review Shannan!

@nichhk nichhk merged commit 3df408a into dev Aug 2, 2022
@nichhk nichhk deleted the 1284-map-should-display-a-loading-modal-when-its-retrieving-new-data branch August 2, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map should display a loading modal when it's retrieving new data
2 participants