Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1252 make date selector work beyond week #1281

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

nichhk
Copy link
Member

@nichhk nichhk commented Jul 14, 2022

Fixes #1252

Major changes:

  • store date ranges for which we have request data in the Redux store
  • when the user changes the date range, check the new date range against the current date ranges that we have data for. Only retrieve data from date ranges which aren't covered.

Note: it is still very slow to get data for a whole month, even though we are making the API requests in parallel: 25s on my local frontend. It might be faster on the actual dev site. But there is no loading modal or anything like that. We'll need to implement that, and try to speed up the server as well.

Note 2: The ReactDayPicker is not very intuitive to use. It will update the date range right after the start date is selected, even though an end date is not selected yet. This will need to be fixed.

Here we can see the density of requests over the past month, totaling 82k requests.
requests-one-month

  • Up to date with dev branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@nichhk nichhk merged commit d74fbfd into dev Jul 14, 2022
@nichhk nichhk deleted the 1252-make-date-selector-work-beyond-week branch July 14, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date Selector not working
1 participant