Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate color for waterwaste #1226

Closed
wants to merge 3 commits into from
Closed

Remove duplicate color for waterwaste #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3319f8e
Remove duplicate color for waterwaste
joshuayhwu Jun 2, 2022
8542aca
Update color mapping in seed file
joshuayhwu Jun 2, 2022
54473ae
Remove outdated comment
joshuayhwu Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/api/alembic/seeds/types.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ type_id,type_name,agency_id,color,description,data_code
7,Metal/Appliances,2,#8B508B,"Air conditioners, dryers, refrigerator and more...",Metal/Household Appliances
8,Single Streetlight,1,#79B74E,"Pole knocked down, streetlight outage on a wooden power pole, or malfunctioning traffic signal",Single Streetlight Issue
9,Multiple Streetlights,1,#EDAD08,"Multiple poles knocked down, streetlight outages on wooden power poles, or malfunctioning traffic signals",Multiple Streetlight Issue
10,Water Waste,1,#EDAD08,"Water runoff, over-watering, incorrect water days, or any other water waste ",Report Water Waste
10,Water Waste,1,#DCED08,"Water runoff, over-watering, incorrect water days, or any other water waste ",Report Water Waste
11,Other,0,#1D6996,Issues that do not fit into any of the other available types,Other
12,Feedback,0,#E17C05,Either follow up on other issues or something that doesn't fit into the other types,Feedback
4 changes: 1 addition & 3 deletions server/dash/design.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@
}


# TODO: Fixing multiple streetlights and waterwaste color
# Request Type Color Hex Code Reference: https://github.com/hackforla/311-data/blob/b0717ad25eab4ef25a2f26da187d9d8905ab5f77/server/api/alembic/seeds/types.csv
# Need to add another discrete color
DISCRETE_COLORS_MAP = {
"Graffiti":"#BF82BA",
"Homeless Encampment":"#11975F",
Expand All @@ -60,7 +58,7 @@
"Metal/Appliances": "#8B508B",
"Single Streetlight": "#79B74E",
"Multiple Streetlights": "#EDAD08",
"Water Waste": "#EDAD08",
"Water Waste": "#DCED08",
"Other": "#1D6996",
"Feedback": "#E17C05"
}
Expand Down