Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zindex to datepicker and footer #1153

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Added zindex to datepicker and footer #1153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afb480a
Added zindex to datepicker and footer
funbunch Nov 10, 2021
782caa5
Removed unnecessary zindex style
funbunch Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/components/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const useStyles = makeStyles(theme => ({
height: theme.footer.height,
width: '100%',
backgroundColor: theme.palette.primary.dark,
zIndex: 1,
},
lastUpdated: {
color: theme.palette.text.dark,
Expand Down
1 change: 1 addition & 0 deletions client/components/common/DatePicker/DatePicker.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ const useStyles = makeStyles(theme => ({
},
selectorPopUp: {
position: 'fixed',
zIndex: 1,
},
button: {
padding: 0,
Expand Down
1 change: 1 addition & 0 deletions client/components/common/ReactDayPicker/Styles.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const Styles = ({ range }) => {
background: ${theme.palette.primary.dark};
border-radius: 5px;
min-width: 268px;
z-index: 5000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding zIndex: 1 to DatePicker.jsx selectorPopUp, is z-index still needed here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I would also recommend using a value that is more consistent with the others, as opposed to an arbitrary large number like 5000 as it will make it easier to manage all the other z-indexes in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated Styles.jsx.

}

.Range .DayPicker-Body {
Expand Down