Integrate Dash reports into the app #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkendis
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Looks good!
I pushed a commit to fix the height and position of the Reports div and the Backdrop. height: 100% wasn't working because the parent div didn't a have non-percentage height specified. I'm guessing that was the footer bug you mentioned, but let me know if there's something else I missed.
Thanks for catching the map bug. I opened ticket #1013. Will fix that this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #837
I'm a little uncertain what the approach is for styling. I got the menu looking OK, but not sure if it's the best approach. Felt like I was fighting Material UI a bit too.
There's also a footer bug with the reports. Hoping someone can help with that.
Also, it looks like the Map isn't properly unloading so it might crash as a result.