Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't want to to edit it #2

Closed
moneymett opened this issue Jun 5, 2019 · 1 comment
Closed

I don't want to to edit it #2

moneymett opened this issue Jun 5, 2019 · 1 comment

Comments

@moneymett
Copy link
Member

No description provided.

ryanmswan added a commit that referenced this issue Dec 5, 2019
JRHutson added a commit that referenced this issue Feb 5, 2020
Merge pull request #230 from JRHutson/master
@jmensch1 jmensch1 mentioned this issue Aug 2, 2020
4 tasks
@croor005
Copy link
Member

croor005 commented Aug 2, 2020

  1. Extract environment variables from cypress code
    I noticed a couple of magic strings in your code that would ideally be put into the environment. These are the ones I'm talking about (and I may have missed some):

CYPRESS_RECORD_KEY -- this can easily be put into a Github secret

MAILOSAUR_API_KEY -- I see this is in the config.js file. Not sure if there's a way cypress can read from the environment (like a .env file or Github secret) to get this value. Possibly also the projectId although I'm not sure it's necessary.

The serverId and testEmail in cypress/integration/email.spec.js

the stuff in cypress_api.spec.js

Cypress.env({
  host: 'veronica.dev.local',
  api_server: 'http://localhost:8888/v1/',
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (without merge)
Development

No branches or pull requests

2 participants