Bugfix: SR RequesetDetail loading spinner not appearing on subsequent mouse-over popups

[ryanfchase]

Overview

We need to fix a bug where the loading spinner on the Service Request inspect modal does not appear on subsequent mouse-overs.

Action Items

In Map.jsx

• Review usage of <RequestDetail/>
• Review usage of this.requesetDetail
• Correct loading behavior of RequestDetail
• Provide SCREEN CAPTURE of the correct behavior

Resources/Instructions

Abbreviations

• Service Request = SR
• Neighborhood Council = NC

Useful Files & Components

• RequestDetail: components/Map/Map/RequestDetail.jsx
• Map: components/Map/Map.jsx

Mapbox Docs:

• API Reference: https://docs.mapbox.com/mapbox-gl-js/api/
• Popup Example: https://docs.mapbox.com/mapbox-gl-js/example/popup/

Reproducing the Bug

1. load the 311 Data site
2. select an NC (e.g. Koreatown)
3. Mouse-over to one SR
   3.1. observe the loading spinner that appears immediately on hover
   3.2. take note of the SR Type.
4. Move-over to a new SR
   4.1. Observe that there is no loading spinner, instead the SR modal is unchanged from step 3
   4.2. Observe that the SR modal will quickly re-render with the correct SR information

Click to see finished result

[TODO: VIDEO GOES HERE]

[ryanfchase]

@bphan002 thanks for picking this up. When you can, please leave as a comment:

• ETA
• availability for comment/discussion

[bphan002]

ETA: Thursday 10/5 3 PM

Availability: Any time before 2 PM

[ryanfchase]

ETA: Thursday 10/5 3 PM

Availability: Any time before 2 PM

@bphan002 did you mean 9/5? 🤣

We can always accommodate if you need more time ofc... 😁

[bphan002]

I did lol sorry

…

On Wed, Sep 4, 2024 at 1:56 PM Ryan Chase ***@***.***> wrote: ETA: Thursday 10/5 3 PM Availability: Any time before 2 PM @bphan002 <https://github.com/bphan002> did you mean 9/5? 🤣 We can always accommodate if you need more time ofc... 😁 — Reply to this email directly, view it on GitHub <#1805 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATZ7FSXARFO6VMYI4ZYTHZDZU5XY7AVCNFSM6AAAAABNPF742OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZQGA2TGMRVGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ryanfchase]

@bphan002 moving this ticket to In Review since your PR is available

[ryanfchase]

Adding my review, eta this evening

[ryanfchase]

@bphan002 I've left you a review on your PR. Please provide an ETA for addressing the review, thanks!

[bphan002]

ETA: Thursday Sept 12 3 PM

[ryanfchase]

Thank you @bphan002, merge when ready