Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revised] Default and Custom Date Filters (Sidebar Filter) #166

Closed
2 tasks done
itsjoycelee opened this issue Jan 12, 2020 · 8 comments · Fixed by #255
Closed
2 tasks done

[Revised] Default and Custom Date Filters (Sidebar Filter) #166

itsjoycelee opened this issue Jan 12, 2020 · 8 comments · Fixed by #255
Assignees
Labels
Role: Frontend React front end work v1 The first version of the site

Comments

@itsjoycelee
Copy link
Contributor

itsjoycelee commented Jan 12, 2020

Overview

Date filters have been designed to show defaulted date filters and custom date filters.

Action Items

  • Create UI for drop down menu that contains

  • Last week

  • Last month

  • Last 6 months

  • Last 12 months

  • Year to date

  • Custom range

  • Create UI for pop-up form for custom range date filter selection

Resources/Instructions

image
^Wireframes 2 (Drop down)

image
^Wireframes 2 (Clicked drop down)

image
^ In components - Wireframes (Selected custom data range - popup form)

Click here for mockup

@ExperimentsInHonesty
Copy link
Member

@johnr54321 @itsjoycelee will update this issue to add instructions for the front end team.

@johnr54321
Copy link
Member

There is a duplicate ticket here: #154. Closed the other ticket. Leaving this one since it has the mockups.

@johnr54321 johnr54321 removed their assignment Feb 1, 2020
@adamkendis
Copy link
Member

@itsjoycelee In the date filter dropdown, should the user be able to click the entire option row or do they need to click the checkbox to make a selection? See image below. Note that the dropdown has not yet been styled to match the mockup - finishing dropdown functionality.

image

@adamkendis
Copy link
Member

Status: Working on date filter dropdown - awaiting minor clarification from UI team. Still need to implement custom range datepicker. Will most likely use an outside package for the datepicker.
Blockers: None at the moment.
Availability: Generally available in the evenings this week. Can handle issues/discussion async via Slack/github comments.
ETA: Hoping to have this feature pushed to dev by Thursday, 2/6.

@itsjoycelee
Copy link
Contributor Author

@adamkendis good point. let's do the entire row than the checkbox option- thanks!

@johnr54321
Copy link
Member

Spoke with Adam. New ETA is 2/11. He needs to look through the library.

@adamkendis
Copy link
Member

Status: Still on track for 2/11 ETA. Dropdown is complete. Working on custom range datepicker and date filter header section.
Blockers: None.
Availability: Available for discussion via Slack/github comments.
ETA: Still 2/11.

Note for later: When hooking these components up to the Redux store, some implementation details will depend on server-side decisions. Will the client need to provide start/end dates to plug into a SQL query on every request, or will the predetermined time blocks (Last week/month/6 months, etc.) be precached on the back end and have their own endpoint(s)?

@ryanmswan
Copy link
Contributor

@adamkendis At this point I think we'll assume that there will be novel SQL queries for update. We're looking into precaching but the time periods are flexible enough that they might be difficult to cache. At this point we're looking at ways to precache the default views as well as maybe the full year view for each year (2015, 2016, ..., 2020)

brodly added a commit that referenced this issue Feb 11, 2020
brodly added a commit that referenced this issue Feb 17, 2020
Closes #166 - Default and Custom Date Filters (Sidebar Filter)
@brodly brodly closed this as completed Feb 17, 2020
@ExperimentsInHonesty ExperimentsInHonesty added the v1 The first version of the site label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Role: Frontend React front end work v1 The first version of the site
Projects
Development

Successfully merging a pull request may close this issue.

7 participants