Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check empty password on password-prompt page load so that rooms without password can be immediately accessed #2421

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Cosmin-Mare
Copy link
Collaborator

@Cosmin-Mare Cosmin-Mare commented Oct 5, 2024

Most elegant solution I could find. fixes #2418

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 7:53am

@Cosmin-Mare Cosmin-Mare added this pull request to the merge queue Oct 9, 2024
Merged via the queue into hackclub:main with commit 8cfc6cd Oct 9, 2024
6 checks passed
@Cosmin-Mare Cosmin-Mare deleted the fix-no-pass-bug branch October 9, 2024 06:23
Cosmin-Mare added a commit to Cosmin-Mare/sprig that referenced this pull request Oct 17, 2024
…ut password can be immediately accessed (hackclub#2421)

Check empty password on page load
Cosmin-Mare added a commit to Cosmin-Mare/sprig that referenced this pull request Oct 28, 2024
…ut password can be immediately accessed (hackclub#2421)

Check empty password on page load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove password request on room with no password
2 participants