Fix bug where room participants wouldn't update #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grymmy
approved these changes
Oct 8, 2024
grymmy
reviewed
Oct 8, 2024
src/components/codemirror.tsx
Outdated
| isHost: state.user.host | ||
| }) | ||
| } catch(e){ | ||
| return |
There was a problem hiding this comment.
is it OK for this to be very quietly failing w/o any logging?
There was a problem hiding this comment.
yup. bc that means that the participant doesn't have an email, therefore it's the saving instance and we don't count that towards the participants
Cosmin-Mare
added a commit
to Cosmin-Mare/sprig
that referenced
this pull request
Oct 17, 2024
* Fix bug where participants wouldn't update * add comments
Cosmin-Mare
added a commit
to Cosmin-Mare/sprig
that referenced
this pull request
Oct 28, 2024
* Fix bug where participants wouldn't update * add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2419