Making the new game button always create a new game #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
grymmy
reviewed
Oct 9, 2024
grymmy
approved these changes
Oct 9, 2024
recursiveforte
approved these changes
Oct 9, 2024
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this pull request
Oct 17, 2024
* making progress on fixing * game saves on login * removing debug stuff * removing more debug stuff * finished css-ing * improved redirect to editor from 'make game' button * Update Maze-escape.js * Update Maze-escape.js * Update memory_game.js * fixing error + adding comment
Cosmin-Mare
pushed a commit
to Cosmin-Mare/sprig
that referenced
this pull request
Oct 28, 2024
* making progress on fixing * game saves on login * removing debug stuff * removing more debug stuff * finished css-ing * improved redirect to editor from 'make game' button * Update Maze-escape.js * Update Maze-escape.js * Update memory_game.js * fixing error + adding comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2205.
First, I changed the flow for making a new game so it actually creates a new game if you're partially logged in (entered an email to get a game link) instead of just sending you to your previous game.
I also added a page that asks the user what they want to do when they ask to create a game but they aren't logged in and have unsaved work in the editor.
