Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak #3

Closed
sporeball opened this issue Nov 25, 2024 · 7 comments
Closed

memory leak #3

sporeball opened this issue Nov 25, 2024 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@sporeball
Copy link
Collaborator

@24c02 just left kicad-wakatime open for the day and didn't think anything of it until it was found to be using 11.6GB of memory.
this is really bad! this should be fixed as soon as possible.

@sporeball sporeball added the bug Something isn't working label Nov 25, 2024
@sporeball
Copy link
Collaborator Author

this is potentially an issue in fltk's font rendering code (cf. here and here).

@sporeball sporeball added the help wanted Extra attention is needed label Nov 26, 2024
@sporeball
Copy link
Collaborator Author

when the egui code from the 0.1.0 branch reaches stable - aiming for sometime before December 12 - i believe the memory leak will be fixed.

@sporeball sporeball added this to the 0.1.0 milestone Dec 4, 2024
@sporeball
Copy link
Collaborator Author

after further inspection, using egui does not appear to fix the memory leak - the new version of the plugin got up to 550MB of memory usage in less than an hour.

@sporeball sporeball modified the milestones: 0.1.0, 0.2.0 Dec 17, 2024
@sporeball
Copy link
Collaborator Author

pushing back to 0.2.0 milestone; we'll see if removing dependence on the KiCAD API will make this a little better.

@sporeball
Copy link
Collaborator Author

using Xcode's Instruments tool on macOS, i've finally isolated the memory leak to the active-win-pos-rs crate, which is used to determine whether KiCAD's schematic editor or PCB editor are being used.
i'll see if i can cut back what it's doing to a form that doesn't leak so much.

@24c02
Copy link
Member

24c02 commented Dec 19, 2024

lol it's always the ones you least suspect

@sporeball
Copy link
Collaborator Author

active-win-pos-rs 0.8.4 will be used in kicad-wakatime 0.1.2 today. closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants