Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hackstone ssl issues #1445

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Fix hackstone ssl issues #1445

merged 2 commits into from
Dec 9, 2024

Conversation

grymmy
Copy link
Contributor

@grymmy grymmy commented Dec 9, 2024

Was getting ssl errors - seen that on other similar deployment, one should create a new domain w/in heroku and bind it like this.

@grymmy grymmy requested review from a team as code owners December 9, 2024 19:38
@grymmy grymmy changed the title This seems to be how at least one other service was set up Fix hackstone ssl issues Dec 9, 2024
Muirrum
Muirrum approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@Muirrum Muirrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document this somewhere :p

@Muirrum Muirrum merged commit 56370bc into hackclub:main Dec 9, 2024
2 checks passed
@grymmy
Copy link
Contributor Author

grymmy commented Dec 9, 2024

document this somewhere :p

well let's see if it actually even works rn not sure if I'm following strong precedent heh

@grymmy
Copy link
Contributor Author

grymmy commented Dec 9, 2024

It worked, yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muirrum Muirrum Muirrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grymmy @Muirrum