create pizza.hackclub.com #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisalsayed10
requested changes
Feb 27, 2024
faisalsayed10
approved these changes
Feb 27, 2024
reesericci
added a commit
that referenced
this pull request
Feb 28, 2024
This reverts commit b90a0d1.
reesericci
reviewed
Feb 28, 2024
| pizza: | ||
| - ttl: 1 | ||
| type: CNAME | ||
| value: hackclub.com/pizza. |
There was a problem hiding this comment.
This is invalid CNAME formatting - CNAMEs don't take pathnames to redirect to since it happens at the DNS level and not the HTTP level. This should be done using a URL record instead.
There was a problem hiding this comment.
yeah you're right, we solved it eventually but forgot to make a pr to delete that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.