Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update polaroid.hackclub.com #1074

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Update polaroid.hackclub.com #1074

merged 3 commits into from
Feb 16, 2024

Conversation

iUnstable0
Copy link
Contributor

For the summit project polaroid cork bulletin board

@iUnstable0 iUnstable0 requested review from a team as code owners February 14, 2024 23:01
reesericci
reesericci suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TTL should be set to something more sane than 1s, something say 600s (10min) or 300s (5min). That way resolvers can cache the record, and it's best practice. Otherwise your record is always expired and it creates a lot more unnecessary requests.

@iUnstable0
Copy link
Contributor Author

oh right, done

@iUnstable0
Copy link
Contributor Author

also theres. alot with ttl 1, should we change it all to sth like 600 or 3600?

@reesericci
Copy link
Contributor

also theres. alot with ttl 1, should we change it all to sth like 600 or 3600?

#1023

@reesericci reesericci self-requested a review February 16, 2024 00:37
reesericci
reesericci approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@reesericci reesericci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reesericci reesericci changed the title Update polaroid.hackclub.com Update polaroid.hackclub.com Feb 16, 2024
@reesericci reesericci merged commit 467d383 into hackclub:main Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reesericci reesericci reesericci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iUnstable0 @reesericci