Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #84

Merged
merged 29 commits into from
Jun 13, 2020
Merged

Refactor #84

merged 29 commits into from
Jun 13, 2020

Conversation

chyku
Copy link
Contributor

@chyku chyku commented May 8, 2020

Status: 🚫

Description 🌟

Fixes #56

TODOs ⭐

  • Standardize button appearance so there's only 3 max classes

  • Standardize color scheme so that similar looking colors that are reused are variables

  • Refactor wordgroupselector to have less code? put names into arrays?

  • src/pages/CustomLessonsDisplay/CustomLessonsDisplay.js setTimeOut() function is sus

  • put pathnames into constants

  • update lessonCard component to be objects instead of arrays with indices corresponding to variables

  • Fixing functionality after adding useCallBack

  • fix word groups in confirmation pg

@chyku chyku marked this pull request as ready for review June 13, 2020 14:54
@chyku chyku merged commit 16b3fc4 into master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring
2 participants