Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gigya client #26

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add Gigya client #26

merged 1 commit into from
Nov 18, 2020

Conversation

epenet
Copy link
Collaborator

@epenet epenet commented Nov 13, 2020 •
edited
Loading

Add Gigya class for handling authentication and authorisation to Renault servers

Depends on #31, #32, #34

@epenet epenet added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 13, 2020
@epenet epenet marked this pull request as draft November 15, 2020 19:31
@epenet epenet changed the title Add gigya Draft: add gigya Nov 15, 2020
@epenet epenet changed the title Draft: add gigya Draft: Add Gigya client Nov 15, 2020
@epenet epenet removed the dependencies Pull requests that update a dependency file label Nov 15, 2020
@epenet epenet changed the title Draft: Add Gigya client Add Gigya client Nov 18, 2020
@epenet epenet marked this pull request as ready for review November 18, 2020 21:42
Quentame
Quentame approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epenet epenet merged commit 0da6276 into develop Nov 18, 2020
@epenet epenet deleted the add-gigya branch November 18, 2020 21:56
epenet added a commit that referenced this pull request Nov 20, 2020
@epenet
Add Gigya client (#26)
98c157b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentame Quentame Quentame approved these changes

@oncleben31 oncleben31 Awaiting requested review from oncleben31

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epenet @Quentame