Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing tests on CI with no locale set #1311

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

EdwardBetts
Copy link
Contributor

Update the tests so they support running on a system where Python is not able to determine the default locale.

Output of a failed build with the default locale is not set is here:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/python-renault-api.html

Update the tests so they support running on a system where Python is
not able to determine the default locale.
@epenet
Copy link
Collaborator

epenet commented Sep 2, 2024

I don't think this is the correct fix.
You are fixing the tests, but you are not fixing running the CLI with no locale set.

default_locale = getdefaultlocale()[0]
while True:
locale = click.prompt("Please select a locale", default=default_locale)

@epenet
Copy link
Collaborator

epenet commented Sep 2, 2024

I don't think this is the correct fix. You are fixing the tests, but you are not fixing running the CLI with no locale set.

Cancel that! I think the fix is correct.

@epenet epenet added the ci Continuous Integration label Sep 2, 2024
Copy link
Collaborator

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 9ed3aff into hacf-fr:main Sep 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants