Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrofit coockiecutter-hypermodern-python 2020.10.15 template #64

Merged
merged 12 commits into from
Oct 20, 2020

Conversation

oncleben31
Copy link
Member

Update meteofrance-api to use the latest improvement of https://github.com/cjolowicz/cookiecutter-hypermodern-python

Major modifications:

  • Add a code of conduct
  • Python 3.9 added and used as default for linting
  • Remove french translation in contributing instruction.

Contribute to #18

@oncleben31 oncleben31 added enhancement New feature or request ci Continuous Integration labels Oct 19, 2020
@oncleben31 oncleben31 requested a review from Quentame October 19, 2020 08:16
@oncleben31
Copy link
Member Author

CI error with Python 3.7 is linked to issue #3160 open in poetry repository.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just waiting the CI to pass before merging.

@oncleben31
Copy link
Member Author

Seems good, just waiting the CI to pass before merging.

Just have downgrade poetry to 1.0.10 to avoid the CI issue. OK to merge ?

Retrofit the update of the cookiecutter-hypermodern-python template.
Add credits to cookiecutter template.
Add reference to pip and PyPI.
Use the updates from cookiecutter-hypermodern-python template.
Previous one was translated in French.
Difficult to maintain the translation and English is almost mandatory on GitHub
to collaboarte efficiently. -> No more translation.
Template file can be reuse as it is.
Remove sphinx_click module and usage page as there is no CLI for meteofrance-api
currently.
Make some small updates in the content.
Add requests_mock dependencie and fix package name.
TypeGuard reveal optional keys in Dict or keys returning None. Python
code have been updated to avoir type hint error messages.
* Downgrad poetry to 1.0.10

* Regenerate lock file for poetry 1.0.10
@oncleben31 oncleben31 merged commit 5556b0c into master Oct 20, 2020
@oncleben31 oncleben31 deleted the cookiecutter branch October 20, 2020 06:49
@oncleben31 oncleben31 linked an issue Oct 21, 2020 that may be closed by this pull request
@oncleben31 oncleben31 removed the enhancement New feature or request label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.9 support
2 participants