-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrofit coockiecutter-hypermodern-python 2020.10.15 template #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI error with Python 3.7 is linked to issue #3160 open in poetry repository. |
Quentame
reviewed
Oct 19, 2020
Quentame
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, just waiting the CI to pass before merging.
Just have downgrade poetry to 1.0.10 to avoid the CI issue. OK to merge ? |
Versions bump
Use the cookiecutter template from https://github.com/cjolowicz/cookiecutter-hypermodern-python
Retrofit the update of the cookiecutter-hypermodern-python template.
Add credits to cookiecutter template. Add reference to pip and PyPI.
Use the updates from cookiecutter-hypermodern-python template.
Previous one was translated in French. Difficult to maintain the translation and English is almost mandatory on GitHub to collaboarte efficiently. -> No more translation. Template file can be reuse as it is.
Remove sphinx_click module and usage page as there is no CLI for meteofrance-api currently. Make some small updates in the content.
Add requests_mock dependencie and fix package name.
TypeGuard reveal optional keys in Dict or keys returning None. Python code have been updated to avoir type hint error messages.
* Downgrad poetry to 1.0.10 * Regenerate lock file for poetry 1.0.10
oncleben31
force-pushed
the
cookiecutter
branch
from
October 20, 2020 06:44
4ed6123
to
ba1c3a1
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update meteofrance-api to use the latest improvement of https://github.com/cjolowicz/cookiecutter-hypermodern-python
Major modifications:
Contribute to #18