Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Add Italian translation #149

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Add Italian translation #149

merged 5 commits into from
Jul 19, 2021

Conversation

Giancky79
Copy link
Contributor

traduzione in italiano

traduzione in italiano
traduzione italiano
Copy link
Collaborator

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments regarding the "keys" which must not be translated.

custom_components/renault/translations/sensor.it.json Outdated Show resolved Hide resolved
custom_components/renault/translations/sensor.it.json Outdated Show resolved Hide resolved
custom_components/renault/translations/sensor.it.json Outdated Show resolved Hide resolved
@epenet epenet changed the title Create sensor.it.json Add Italian translations Jul 15, 2021
@epenet epenet changed the title Add Italian translations Add Italian translation Jul 15, 2021
@epenet
Copy link
Collaborator

epenet commented Jul 15, 2021

cc @VaguerOdin

@epenet epenet linked an issue Jul 15, 2021 that may be closed by this pull request
Copy link
Contributor Author

@Giancky79 Giancky79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i'm translate on a copy of custom and not correct after all, sorry

@VaguerOdin
Copy link

cc @VaguerOdin

Hi, as I said yesterday the only comment I would make Is about the correct Eng-Ita translation. (Of course for the parts that can be translated)

For "renault__plug_state" should be:

"unplugged": "Scollegata",
"plugged": "Collegata",
"plug_error": "Errore collegamento",
"plug_unknown": "Collegamento sconosciuto"

For "renault__charge_state" would be:

"not_in_charge": "Non in carica",
"waiting_for_a_planned_charge": "In attesa della ricarica in programma",
"charge_ended": "Ricarica terminata",
"waiting_for_current_charge": "In attesa dell'attuale ricarica",
"energy_flap_opened": "Sportello di ricarica aperto",
"charge_in_progress": "In carica",
"charge_error": "Errore: Non in carica o scollegata",
"unavailable": "Non disponibile"

For "renault__charge_mode" would be:

"always": "Istantanea",
"always_charging": "Istantanea",
"schedule_mode": "Programmata"

Translation would be useless if we translate badly. Sorry for the delay.
Jess

@epenet
Copy link
Collaborator

epenet commented Jul 16, 2021

@Giancky79 can you please update the PR to take into account the recommendations from @VaguerOdin? (or explain why you don't think the recommendations are invalid)

@Giancky79
Copy link
Contributor Author

Schermata 2021-07-16 alle 16 23 18

yesterday i had fix it but i can't merge it, make new request?

@Giancky79 Giancky79 requested a review from epenet July 16, 2021 14:26
@epenet
Copy link
Collaborator

epenet commented Jul 16, 2021

You don't need to worry about the workflow. I will enable it after you have updated the files in your branch.
Or @VaguerOdin can convert the comments to "code suggestions" that can be merged.

@Giancky79
Copy link
Contributor Author

ok, that's all, we hope in a future italian traslation 😄

@@ -0,0 +1,37 @@
{
"config: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing quote:

Suggested change
"config: {
"config": {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry

@epenet epenet merged commit c1c3d65 into hacf-fr:master Jul 19, 2021
@epenet epenet added the enhancement New feature or request label Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

italian translations
3 participants