Update documenentation and examples for OAuth providers #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefsalim
reviewed
May 9, 2018
README.md
Outdated
| @@ -53,7 +53,7 @@ You may need to work with your enterprise network admin to enable the appropriat | |||
|
|
|||
| ### OAuth Application | |||
|
|
|||
| We currently support Azure AD (OpenId Connect), GitHub, GitLab and Atlassian Bitbucket OAuth providers for authentication. You will need to set up an OAuth application for the instance of the depot you are setting up. | |||
| We currently support Azure AD (OpenId Connect), GitHub, GitLab, Okta and Atlassian Bitbucket OAuth providers for authentication. You will need to set up an OAuth application for the instance of the depot you are setting up. | |||
There was a problem hiding this comment.
Would be good to add (OpenId Connect) to the Gitlab and Okta providers.
There was a problem hiding this comment.
I've updated the README
Signed-off-by: Kristian Vlaardingerbroek <[email protected]>
rarenerd
force-pushed
the
update-docs-okta-gitlab
branch
from
3042f7a
to
2eb5bf0
Compare
chefsalim
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the documentation and add example environment variables for Okta and the updated GitLab support.
I've also added documentation links for the other services.
This depends on habitat-sh/builder#417 and habitat-sh/builder#420 becoming available in stable.