Pipeline setup for aarch64-linux #9326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-habitat processing.
|
sajjaphani
force-pushed
the
aarch64-linux-cicd
branch
from
32d324c to
73c5c5e
Compare
sajjaphani
force-pushed
the
aarch64-linux-cicd
branch
from
c209bad to
3abacab
Compare
sajjaphani
force-pushed
the
aarch64-linux-cicd
branch
from
779441c to
9f477a1
Compare
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
sajjaphani
force-pushed
the
aarch64-linux-cicd
branch
from
2a18755 to
f5eb005
Compare
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
Signed-off-by: Phani Sajja <[email protected]>
mwrock
reviewed
Nov 8, 2024
| @@ -38,6 +38,15 @@ steps: | |||
| environment: | |||
| - BUILD_PKG_TARGET=x86_64-linux | |||
|
|
|||
There was a problem hiding this comment.
can we remove the [:linux: build hab (ARM)] build above?
| agents: | ||
| queue: default-privileged-aarch64 | ||
| env: | ||
| HAB_FALLBACK_CHANNEL: "lts24-aarch64-linux" |
There was a problem hiding this comment.
can we move this channel into LTS-2024?
| command: | ||
| - sudo -E .expeditor/scripts/release_habitat/package_and_upload_binary.sh | ||
| if: build.creator.name == 'Chef Expeditor' || build.env("UPLOAD_AND_PROMOTE") == 'true' | ||
|
|
||
| - label: "[:linux: :two: upload hab binary]" |
There was a problem hiding this comment.
we need a ARM :docker: Upload containers to Docker Hub too right?
There was a problem hiding this comment.
Yes, Will do that in a seperate PR!
| export rustc_target="x86_64-unknown-linux-musl" | ||
| # With the musl target, the ring crate is looking for aarch64-linux-musl-gcc, | ||
| # but the core/musl package provides musl-gcc. This workaround is necessary until the appropriate changes are made to core/musl for aarch64. | ||
| if [[ "${pkg_target%%-*}" == "aarch64" ]]; then |
There was a problem hiding this comment.
do you think this is something that needs to be changed in the aarch64 core/musl package itself?
There was a problem hiding this comment.
Yes, I will raise a PR in core-packages as it requires some work. Once those changes are in place, I can update this.
| package_path=${1?package_path argument required} | ||
|
|
||
| # Install hab from a temporarily uploaded aarch64 package | ||
| curl https://raw.githubusercontent.com/habitat-sh/habitat/main/components/hab/install.sh | sudo bash -s -- -t "$BUILD_PKG_TARGET" -c "$HAB_FALLBACK_CHANNEL" -v 1.6.1178 |
There was a problem hiding this comment.
could we just put this package in stable and not need to rely on a specific build number? I don't see a problem with that since we have not publicized arm support and it wouldn't be possible for customers to see it on the official downloads site.
There was a problem hiding this comment.
Once this is merged, I am thinking of updating the channel to dev to build the latest hab and update the pipeline. If that doesn’t work, I can promote the build created by the release pipeline and then update it here.
Signed-off-by: Phani Sajja <[email protected]>
mwrock
approved these changes
Nov 15, 2024
|
@sajjaphani let's hold off merging this until after next week's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hab*packages are rebuilt against LTS-2024 and uploaded to the SaaS builder (version 1.6.1178). These temporarily built artifacts are used by the verification pipeline for building and testing purposes.