Standardize how tilde is used for templating in core plans

[predominant]

A re-implementation of #853.

Signed-off-by: Graham Weldon [email protected]

[thesentinels]

Thanks for the pull request! Here is what will happen next:

1. Your PR will be reviewed by the maintainers
2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

[tduffield]

@predominant looks like Travis is failing :(

[predominant]

@tduffield Yeah, its failing on stuff that I don't know how to work around right now, where inclusions are unable to be sourced and checked due to templating:

Unable to check included file: {{pkg.svc_config_path}}/environment.sh
Unable to check included file: {{pkg.svc_config_path}}/functions.sh
Unable to check included file: {{pkg.svc_config_path}}/functions.sh
Unable to check included file: {{pkg.svc_config_path}}/environment.sh
Unable to check included file: {{pkg.svc_config_path}}/functions.sh
Unable to check included file: {{pkg.svc_config_path}}/environment.sh
Unable to check included file: {{pkg.svc_config_path}}/functions.sh

[nellshamrell]

Unfortunately, do to the age of this PR and the number of plans it changes, along with the merge conflicts that have emerged due to the age, I'm going to go ahead and close this PR. @predominant - if this is something you would still like to see done, please feel free to open an RFC, we require an RFC for any pull request that is going to affect more than 1 or 2 plans. Thank you for the work you put into this, it is still very much appreciated!

[predominant]

Thanks @nellshamrell