-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package.json): edit main, exports and publishConfig to improve DX #228
Conversation
|
✅ Deploy Preview for storybook-h6s ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for h6s-react-examples canceled.
|
✅ Deploy Preview for h6s-dev canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for Contribute.
I would appreciate it if you could change the order of the exports fields(types first) by referring to below information. 👇
microsoft/TypeScript#46334
cc @JaeYeopHan
750ecaa
to
30c0099
Compare
I changed order of exports as your link reference's advice. I tried to reproduce problem situation. but actually, I couldn't reproduce it what you worried. so I couldn't get confidence at this implementation. If my change is wrong, could you make some suggestion code for me? I just want to know what you want exactly. |
I don't know how you tried it, but as written in the issue above, in an environment using (ts) btw, i'll investigate broken netlify issues... I don't think it's because of this change 🤔, but can you wait a moment? 🙏 🙏 |
rebase please |
@manudeli sorry i cant rebase this pr (this pr is created through a forked repo 😅) |
4268911
to
5d99463
Compare
@JaeYeopHan @SoYoung210 Rebasing done |
# [@h6s/calendar-v1.0.8-alpha.1](https://github.com/h6s-dev/h6s/compare/@h6s/calendar-v1.0.7...@h6s/calendar-v1.0.8-alpha.1) (2022-12-21) ### Bug Fixes * **package.json:** edit main, exports and publishConfig to improve DX ([#228](#228)) ([d5271de](d5271de))
🎉 This PR is included in version @h6s/calendar-v1.0.8-alpha.1 🎉 |
# [@h6s/table-v1.0.5-alpha.1](https://github.com/h6s-dev/h6s/compare/@h6s/table-v1.0.4...@h6s/table-v1.0.5-alpha.1) (2022-12-21) ### Bug Fixes * **package.json:** edit main, exports and publishConfig to improve DX ([#228](#228)) ([d5271de](d5271de))
🎉 This PR is included in version @h6s/table-v1.0.5-alpha.1 🎉 |
Edit main, exports and publishConfig to improve DX
Cannot find module directly, if contributors didn't build packages.
Though there is built packages, Contributor want to access source itself, not built package.
Solution I thought
How about making vscode access to workspaces source code directly, not built package. if package.json using publishConfig, making built package and developing package in workspaces for DX separately is available.