Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DevDeps Update and Minor docs links update #2263

Merged
merged 1 commit into from
Jun 4, 2020
Merged

DevDeps Update and Minor docs links update #2263

merged 1 commit into from
Jun 4, 2020

Conversation

coliff
Copy link
Member

@coliff coliff commented Jun 4, 2020

  • Ran npm update and npm install and tested - all good
  • Removed the language param from the Google links - they work without them makes links shorter and could be beneficial to non-English speakers (if docs are localized)
  • Fixed invalid markdown URL for link to AnonymizeIP
  • Added a missing comma in the README.md

@coliff
DevDeps Update and Minor docs links update
e069405 
+ Ran npm update and npm install and tested - all good
+ Removed the language param from the Google links - they work without them makes links shorter and could be beneficial to non-english speakers (if docs are localized)
+ Fixed invalid markdown URL for link to AnonymizeIP
+ Added a missing comma in the README.md
@coliff coliff requested a review from roblarsen June 4, 2020 09:01
@roblarsen roblarsen merged commit 96bfe28 into master Jun 4, 2020
@coliff coliff deleted the v8-dist-fix-and-docs-links branch June 4, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblarsen roblarsen roblarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coliff @roblarsen