Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds web app manifest file #1963

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Adds web app manifest file #1963

merged 1 commit into from
Jul 11, 2017

Conversation

roblarsen
Copy link
Member

closes #1629

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

This is a clean update of the original PR. The changes were easy enough and I was eyeing that other PR warily.

I'll add documentation this week as part of a documentation pass (unless someone else wants to add some documentation- I will merge the heck out of those PRs)

@roblarsen roblarsen merged commit bc2710e into h5bp:master Jul 11, 2017
@roblarsen roblarsen mentioned this pull request Jul 11, 2017
18 tasks
jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017
@coliff
Copy link
Member

coliff commented Aug 30, 2018

oops. realised we don't have any documentation about the webapp manifest. I'll get something together and make a PR.

@roblarsen
Copy link
Member Author

It's in the HTML docs, but is very basic.

@coliff
Copy link
Member

coliff commented Aug 30, 2018

ah yes, sorry. That looks fine actually...

@roblarsen roblarsen deleted the manifest-2 branch February 8, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants