Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jQuery 3.2.1 #1942

Merged
merged 3 commits into from
Jul 6, 2017
Merged

Update to jQuery 3.2.1 #1942

merged 3 commits into from
Jul 6, 2017

Conversation

coliff
Copy link
Member

@coliff coliff commented May 12, 2017

Update to jQuery 3.2.1

Update to jQuery 3.2.1
@peterblazejewicz
Copy link

peterblazejewicz commented May 14, 2017

Hey, that's not enough I think. One needs to update dev dependencies in the first place:
https://github.com/h5bp/html5-boilerplate/blob/master/package.json#L19
so entire build process for H5BP is correctly updated. The dist content is generated by tooling:
https://github.com/h5bp/html5-boilerplate/blob/master/gulpfile.babel.js

@coliff
Copy link
Member Author

coliff commented May 15, 2017

Thanks for the headsup @peterblazejewicz - I updated the PR after running Gulp on gulpfile.babel.js

@coliff
Copy link
Member Author

coliff commented Jul 6, 2017

Hi @roblarsen - can we get this one merged for 6.0?

@roblarsen roblarsen merged commit e7fe855 into h5bp:master Jul 6, 2017
jeffreznik pushed a commit to jeffreznik/sw-test that referenced this pull request Oct 15, 2017
* Update to jQuery 3.2.1

Update to jQuery 3.2.1

* Update package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants