MSVC compatibility #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which is version of MSVC used by you? Seems that some guys already use AvCpp with MSVC without problems... So, I am confused a little bit. |
|
I use VS2017 latest, which would be the toolset v141. I think most of these problems could be fixed by disabling some warnings or such, but I don't see how ssize_t would work unless it was manually typedef'd. The other stuff too won't work in msvc by default. |
|
Ok. Could you please split merge request to the set of separate ones? I am ready to apply some changes now, but some changes need more deep review. |
|
Only first. I want look deeply to the |
|
Could you please prepare PR for 42c74d4 too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR change some parts of the code to be compatible with MSVC. I haven't tested it on gcc for cross compatibility, but it should be fine.
I'm not happy about the AV_TIMEBASE_Q_CPP macro, but I couldn't think of a properly elegant solution.