Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close sidebar before changing account #783

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Close sidebar before changing account #783

merged 1 commit into from
Dec 12, 2018

Conversation

amyspark
Copy link
Contributor

If the sidebar is open while changing accounts, Whalebird will throw an error about retrieving toot detail/account profile/timeline. This is because, in between changes, the API endpoint points to localhost, and this triggers a redraw of the Vue components.
This pull request prevents this issue by previously closing the sidebar.

@h3poteto h3poteto merged commit e10b32f into h3poteto:master Dec 12, 2018
@amyspark amyspark deleted the fix-sidebar-error branch December 12, 2018 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants