Enable account dropdown in narrow sidebar menu #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3poteto
reviewed
Nov 26, 2018
h3poteto
reviewed
Nov 26, 2018
|
Could you show me any sample image? I want to confirm the appearance. |
|
Sure! I took these in a Windows box. (They are the same whether one shows or not the account sidebar.) These show the side menu. You'll see the wide one hasn't changed at all: These show the dropdown control. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request lets the user access the account dropdown even with the narrow menu.
I've also adjusted the CSS to use flex everywhere.